-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document new experimental ingestion streaming APIs #8123
Conversation
Signed-off-by: Andriy Redko <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Thank you, @reta! I made some edits and pushed into your PR. Please verify that everything is still technically accurate. Also, I changed the bulk request to curl so please verify that the request is formatted correctly. Will this bulk request work in Dev Tools of OS Dashboards? (not sure if it'll work with the 2 headers). |
Also, please provide an issue where the users can track the progress of the feature. Or we can just direct them to the OS forum. |
Signed-off-by: Andriy Redko <[email protected]>
Thanks a lot @kolchfa-aws , I also made the required changes, looks good to me! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @reta! I think we can still keep the json
highlighting on the curl code block. Technically, it's not JSON, but I like the way the curly braces are matched and the field names are all the same color :) Applying "Done but waiting to merge" label to put this in the 2.17 editorial queue starting 9/11. This PR will be merged before the release.
Signed-off-by: Andriy Redko <[email protected]>
Got it, brought it back, thanks @kolchfa-aws ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reta @kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!
`wait_for_active_shards` | String | Specifies the number of active shards that must be available before OpenSearch processes the bulk request. Default is 1 (only the primary shard). Set to `all` or a positive integer. Values greater than 1 require replicas. For example, if you specify a value of 3, the index must have two replicas distributed across two additional nodes for the request to succeed. | ||
`batch_interval` | Time | Specifies how long bulk operations should be accumulated into batch before sending over to data nodes. | ||
`batch_size` | Time | Specifies how many bulk operations should be accumulated into batch before sending over to data nodes. Default `1`. | ||
{% comment %}_source | List | asdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this and the following two rows be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should (by API specs)
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
…t#8123) * Document new experimental ingestion streaming APIs Signed-off-by: Andriy Redko <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Small rewording Signed-off-by: Fanit Kolchina <[email protected]> * Address review comments Signed-off-by: Andriy Redko <[email protected]> * Address review comments Signed-off-by: Andriy Redko <[email protected]> * Address review comments Signed-off-by: Andriy Redko <[email protected]> * Address review comments Signed-off-by: Andriy Redko <[email protected]> * Address review comments Signed-off-by: Andriy Redko <[email protected]> * Address review comments Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Signed-off-by: Noah Staveley <[email protected]>
Description
Document new experimental ingestion streaming APIs
Issues Resolved
Closes #8111
Version
2.17.0
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.